Addition of getRegisteredSyncRoots Method to Addon and Exposure as Static Function #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // GetRegisteredSyncRootsWrapper | ||
| napi_property_descriptor getRegisteredSyncRootsRootDesc = { |
Contributor
There was a problem hiding this comment.
Is this write well? SyncRootsRoot?
Contributor
Author
There was a problem hiding this comment.
mmm it's true that it looks weird but all wrappers have the RootDesc at the end
| throw std::runtime_error("Error creando la cadena id"); | ||
| napi_set_named_property(env, jsObj, "id", napiId); | ||
|
|
||
| // Propiedad "path" |
Contributor
There was a problem hiding this comment.
Place excpetions and comments in english
| status = napi_create_object(env, &jsObj); | ||
| if (status != napi_ok) | ||
| throw std::runtime_error("Error creando el objeto"); | ||
|
|
Contributor
There was a problem hiding this comment.
And here I assume it should be // Property "id"
dajimenezriv-internxt
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces a new method in the addon to retrieve the registered synchronization root folders and exposes it as a static function to facilitate its use.